Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions
Date
Msg-id 8935187f-0312-afd6-142a-f48142178dcb@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
Tree view 
On 23.11.22 14:57, Aleksander Alekseev wrote:
> Hi Andres,
> 
> Thanks for the review!
> 
>> I don't think it is correct for any of these to add const. The only reason it
>> works is because of casting etc.
> 
> Fair enough. PFA the corrected patch v2.

This patch version looks correct to me.  It is almost the same as the 
one that Andres had posted in his thread, except that yours also 
modifies slist_delete() and dlist_member_check().  Both of these changes 
also look correct to me.

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Schema variables - new implementation for Postgres 15 (typo)
Next
From: Dilip Kumar
Date:
Subject: Re: Perform streaming logical transactions by background workers and parallel apply