Remove redundant if-else in EXPLAIN by using ExplainPropertyText - Mailing list pgsql-hackers

From Ilia Evdokimov
Subject Remove redundant if-else in EXPLAIN by using ExplainPropertyText
Date
Msg-id 88a71bcd-0b5c-4d0b-8107-757e96f402d5@tantorlabs.com
Whole thread Raw
Responses Re: Remove redundant if-else in EXPLAIN by using ExplainPropertyText
List pgsql-hackers
Hi hackers,

Thanks to David [0], we found that the if and else branches contained 
equivalent code. Since ExplainPropertyText already handles non-text 
formats, the extra condition is unnecessary.

I reviewed other files related to EXPLAIN where similar patterns might 
exist, but this was the only instance I found.

I’m attaching a patch with the fix. If anyone spots a similar case 
elsewhere, please let me know.

[0]: 
https://www.postgresql.org/message-id/CAApHDvpq2gOt3gnzkd4Ud%3DwrT7YRGrF3zb29jgWzDsYEhETrOA%40mail.gmail.com

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

Attachment

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: optimize file transfer in pg_upgrade
Next
From: Tom Lane
Date:
Subject: Re: Not-terribly-safe checks for CRC intrinsic support