Re: Add Nullif case for eval_const_expressions_mutator - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add Nullif case for eval_const_expressions_mutator
Date
Msg-id 883197.1610382053@sss.pgh.pa.us
Whole thread Raw
In response to Add Nullif case for eval_const_expressions_mutator  ("Hou, Zhijie" <houzj.fnst@cn.fujitsu.com>)
Responses RE: Add Nullif case for eval_const_expressions_mutator  ("Hou, Zhijie" <houzj.fnst@cn.fujitsu.com>)
List pgsql-hackers
"Hou, Zhijie" <houzj.fnst@cn.fujitsu.com> writes:
> I notice that there are no Nullif case in eval_const_expression.
> Since Nullif is similar to Opexpr and is easy to implement,
> I try add this case in eval_const_expressions_mutator.

I think this patch should be about a tenth the size.  Try modeling
it on the T_SubscriptingRef-etc case, ie, use ece_generic_processing
and then ece_evaluate_expr to cover the generic cases.  OpExpr is
common enough to deserve specially optimized code, but NullIf isn't,
so shorter is better.

            regards, tom lane



pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: popcount
Next
From: Bruce Momjian
Date:
Subject: Re: Moving other hex functions to /common