Re: A out of date comment of WaitForWALToBecomeAvailable - Mailing list pgsql-hackers

From Andy Fan
Subject Re: A out of date comment of WaitForWALToBecomeAvailable
Date
Msg-id 87zf4pu4ca.fsf@163.com
Whole thread Raw
In response to Re: Re: A out of date comment of WaitForWALToBecomeAvailable  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi All,

> [[PGP Signed Part:Undecided]]
> On Mon, Feb 02, 2026 at 10:37:43AM +0800, Xuneng Zhou wrote:
>> WaitForWALToBecomeAvailable can also return XLREAD_WOULDBLOCK when the
>> caller set nonblocking. The comment only talks about XLREAD_FAIL vs
>> “waits in standby,” so it still doesn’t describe that third outcome.
>> That omission pre-dates this patch, should we expand the comment
>> mention the nonblocking case as well?
>
> The outcome related to XLREAD_WOULDBLOCK is implied in the last
> sentence of the comment block standing at the top of the function,
> which seems OK to me.

Thank you for the double check, I personally prefer to keep
XLREAD_WOULDBLOCK as it it.

--
Best Regards
Andy Fan




pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: doc: Clarify that empty COMMENT string removes the comment
Next
From: David Rowley
Date:
Subject: Re: Reduce planning time for large NOT IN lists containing NULL