Request a Demo
Home   >   mailing lists

Re: doc: Clarify that empty COMMENT string removes the comment - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: doc: Clarify that empty COMMENT string removes the comment
Date
Msg-id CAHGQGwFSxdXh-LsSTj+EE6VhJm6XjpgiH42kUsUDxgXViFn-Cg@mail.gmail.com
Whole thread
In response to Re: doc: Clarify that empty COMMENT string removes the comment  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: doc: Clarify that empty COMMENT string removes the comment
List pgsql-hackers
Tree view 
On Tue, Mar 3, 2026 at 8:42 AM Chao Li <li.evan.chao@gmail.com> wrote:
>
>
>
> > On Feb 28, 2026, at 09:21, David G. Johnston <david.g.johnston@gmail.com> wrote:
> >
> > On Fri, Feb 27, 2026 at 5:12 PM Chao Li <li.evan.chao@gmail.com> wrote:
> >
> > PFA v3.

Thanks for updating the patch! LGTM

One more comment: the handling of empty-string comments exists in both
CreateComments() and CreateSharedComments(). For better test coverage,
how about adding also the regression test to check that COMMENT with
empty-string works as expected for shared objects such as roles?

Regards,

--
Fujii Masao

pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
Next
From: Andy Fan
Date:
Subject: Re: A out of date comment of WaitForWALToBecomeAvailable