Re: [PATCH] Cleanup of GUC units code - Mailing list pgsql-hackers

From Gregory Stark
Subject Re: [PATCH] Cleanup of GUC units code
Date
Msg-id 87tzcq3bx8.fsf@oxford.xeocode.com
Whole thread Raw
In response to Re: [PATCH] Cleanup of GUC units code  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> writes:

> Gregory Stark <stark@enterprisedb.com> writes:
>> Alvaro Herrera <alvherre@commandprompt.com> writes:
>>> It's good as a joke, but what if the user says '1024b'?  Does it mean
>>> 1024 blocks or one kilobyte?  If blocks, what size are we talking, the
>>> usual 512 bytes, or our BLCKSZ?
>
>> For what guc would you find a unit of posix-style "blocks" relevant?!
>
> The point isn't whether it's relevant, the point is that there's a
> fairly serious doubt as to what the user thought it meant.

My point was that we don't accept any form of "b" today and nobody has
suggested we should.

--  Gregory Stark EnterpriseDB          http://www.enterprisedb.com Ask me about EnterpriseDB's RemoteDBA services!


pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Common Table Expressions (WITH RECURSIVE) patch
Next
From: Chris Browne
Date:
Subject: Fast REVERSE() function?