Re: [PATCH] Cleanup of GUC units code - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Cleanup of GUC units code
Date
Msg-id 15304.1220886165@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Cleanup of GUC units code  (Gregory Stark <stark@enterprisedb.com>)
Responses Re: [PATCH] Cleanup of GUC units code  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-hackers
Gregory Stark <stark@enterprisedb.com> writes:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
>> It's good as a joke, but what if the user says '1024b'?  Does it mean
>> 1024 blocks or one kilobyte?  If blocks, what size are we talking, the
>> usual 512 bytes, or our BLCKSZ?

> For what guc would you find a unit of posix-style "blocks" relevant?!

The point isn't whether it's relevant, the point is that there's a
fairly serious doubt as to what the user thought it meant.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Gregory Stark
Date:
Subject: Re: [PATCH] Cleanup of GUC units code
Next
From: Markus Wanner
Date:
Subject: Re: Synchronous Log Shipping Replication