Re: Patch for str_numth() in PG 7.4 - Mailing list pgsql-hackers

From Gregory Stark
Subject Re: Patch for str_numth() in PG 7.4
Date
Msg-id 87tz84jdj3.fsf@oxford.xeocode.com
Whole thread Raw
In response to Patch for str_numth() in PG 7.4  (Andreas 'ads' Scherbaum <adsmail@wars-nicht.de>)
List pgsql-hackers
Andreas 'ads' Scherbaum <adsmail@wars-nicht.de> writes:

> I tracked the problem done to the function str_numth() in
> src/backend/utils/adt/formatting.c. The fix (attached) is easy: i
> stole the function code from the latest 8.0 version which looks fare
> more sane in handling the string pointers.

I think you attached the wrong patch.

> *** src/bin/psql/describe.c    2008-12-21 13:19:40.000000000 +0100
> --- src/bin/psql/describe.c.orig    2008-12-21 02:16:31.000000000 +0100
> ***************
> *** 464,476 ****
>                             "       d.datctype as \"%s\",\n",
>                             gettext_noop("Collation"),
>                             gettext_noop("Ctype"));
> !     if (pset.sversion >= 80100)
> !         appendPQExpBuffer(&buf,
> !                       "       pg_catalog.array_to_string(d.datacl, E'\\n') as \"%s\"",
> !                       gettext_noop("Access Privileges"));
> !     else
> !         appendPQExpBuffer(&buf,
> !                       "       pg_catalog.array_to_string(d.datacl, '\\n') as \"%s\"",
>                         gettext_noop("Access Privileges"));
>       if (verbose && pset.sversion >= 80200)
>           appendPQExpBuffer(&buf,
> --- 464,471 ----
>                             "       d.datctype as \"%s\",\n",
>                             gettext_noop("Collation"),
>                             gettext_noop("Ctype"));
> !     appendPQExpBuffer(&buf,
> !                       "       d.datacl as \"%s\"",
>                         gettext_noop("Access Privileges"));
>       if (verbose && pset.sversion >= 80200)
>           appendPQExpBuffer(&buf,

--  Gregory Stark EnterpriseDB          http://www.enterprisedb.com Ask me about EnterpriseDB's RemoteDBA services!


pgsql-hackers by date:

Previous
From: Andreas 'ads' Scherbaum
Date:
Subject: Patch for str_numth() in PG 7.4
Next
From: Andreas 'ads' Scherbaum
Date:
Subject: Re: Patch for str_numth() in PG 7.4