Re: Too rigorous assert in reorderbuffer.c - Mailing list pgsql-hackers

From Arseny Sher
Subject Re: Too rigorous assert in reorderbuffer.c
Date
Msg-id 87tvh9xa0g.fsf@ars-thinkpad
Whole thread Raw
In response to Re: Too rigorous assert in reorderbuffer.c  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Too rigorous assert in reorderbuffer.c  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:

>> I thought the blanket removal of the assert() was excessive, and we can
>> relax it instead; what do you think of the attached?
>
> More precisely, my question was: with this change, does the code still
> work correctly in your non-toy case?

Yes, it works. I thought for a moment that some obscure cases where cmax
on a single tuple is not strictly monotonic might exist, but looks like
they don't. So your change is ok for me, reshaping assert is better than
removing. make check is also good on all supported branches.


--
Arseny Sher
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Should we still have old release notes in docs?
Next
From: Tom Lane
Date:
Subject: Re: Should we still have old release notes in docs?