Re: Slim down integer formatting - Mailing list pgsql-hackers

From Andrew Gierth
Subject Re: Slim down integer formatting
Date
Msg-id 87tukgfj5v.fsf@news-spur.riddles.org.uk
Whole thread Raw
In response to Slim down integer formatting  (David Fetter <david@fetter.org>)
Responses Re: Slim down integer formatting  (Greg Nancarrow <gregn4422@gmail.com>)
List pgsql-hackers
>>>>> "David" == David Rowley <dgrowleyml@gmail.com> writes:

 David> I think the mistake is that the header file is not in
 David> src/include/common. For some reason, it's ended up with all the
 David> .c files in src/common.

 David> I imagine Andrew did this because he didn't ever expect anything
 David> else to have a use for these. He indicates that in [1].

 David> Maybe Andrew can confirm?

It's not that anything else wouldn't have a use for those, it's that
anything else SHOULDN'T have a use for those because they are straight
imports from upstream Ryu code, they aren't guaranteed to work outside
the ranges of values required by Ryu, and if we decided to import a
newer copy of Ryu then it would be annoying if any other code was broken
as a result.

In short, please don't include d2s_intrinsics.h from anywhere other than
d2s.c

-- 
Andrew.



pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: Some code cleanup for pgbench and pg_verifybackup
Next
From: Amit Kapila
Date:
Subject: Re: [bug?] Missed parallel safety checks, and wrong parallel safety