Re: fix recent WITH OIDS bug - Mailing list pgsql-patches

From Neil Conway
Subject Re: fix recent WITH OIDS bug
Date
Msg-id 87r7xrh6ab.fsf@mailbox.samurai.com
Whole thread Raw
In response to Re: fix recent WITH OIDS bug  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: fix recent WITH OIDS bug  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane <tgl@sss.pgh.pa.us> writes:
> You could possibly put it next to the existing function
> interpretInhOption(), which does essentially the same kind of thing
> and for the same reason.  However, I can't argue that that
> function's placement in parse_clause.c has any real strong
> motivation either...

Yeah, I had considered that, but hesitated for the same reason you
cite. Is it worth creating a parse_util.c, perhaps? makeObjectName()
and CheckSelectForUpdate() from analyze.c might be worth moving there
as well...

-Neil


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: fix recent WITH OIDS bug
Next
From: Tom Lane
Date:
Subject: Re: fix recent WITH OIDS bug