Re: pgsql: Fix an oversight in the 8.2 patch that improved mergejoin - Mailing list pgsql-committers

From Gregory Stark
Subject Re: pgsql: Fix an oversight in the 8.2 patch that improved mergejoin
Date
Msg-id 87myilzdg3.fsf@oxford.xeocode.com
Whole thread Raw
In response to pgsql: Fix an oversight in the 8.2 patch that improved mergejoin  (tgl@postgresql.org (Tom Lane))
Responses Re: pgsql: Fix an oversight in the 8.2 patch that improved mergejoin  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-committers
tgl@postgresql.org (Tom Lane) writes:

> (The materialize protects the sort from having to support mark/restore,
> allowing it to do its final merge pass on-the-fly.) We neglected to teach
> cost_mergejoin about that hack, so it was failing to include the
> materialize's costs in the estimated cost of the mergejoin.

Is that right? The materialize is just doing the same writing that the final
pass of the sort would have been doing. Did we discount the costs for sort for
that skipping writing that final pass when that was done?

--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com
  Ask me about EnterpriseDB's 24x7 Postgres support!

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Implement a psql command "\ef" to edit the definition of a
Next
From: Simon Riggs
Date:
Subject: Re: pgsql: Fix an oversight in the 8.2 patch that improved mergejoin