Re: Patch to bring \copy syntax more in line with SQL - Mailing list pgsql-patches

From Neil Conway
Subject Re: Patch to bring \copy syntax more in line with SQL
Date
Msg-id 87k73mi4dh.fsf@mailbox.samurai.com
Whole thread Raw
In response to Patch to bring \copy syntax more in line with SQL copy  (Bill Moran <wmoran@potentialtech.com>)
Responses Re: Patch to bring \copy syntax more in line with SQL copy  (Bill Moran <wmoran@potentialtech.com>)
List pgsql-patches
A few quick comments:

- don't use C++-style comments

- please update the documentation

- update the comment at the top of copy.c

Bill Moran <wmoran@potentialtech.com> writes:
> Ideally, this should cover all cases of old and new syntax, except
> where "AS" is present.

ISTM it would be easy to allow for an optional 'AS' token following
the 'DELIMITER[S]' token.

> The only drawback I can see is that \copy is now more liberal in
> what it accepts, and may accept incomplete statements without
> issuing an error (i.e. a WITH or USING clause at the end of a \copy
> statement will simply be ignored, and no error generated)

Why can't you check for this?

-Neil


pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: Patch for search_path --- apply to 7.4 branch?
Next
From: Tom Lane
Date:
Subject: Re: Current-stream read for psql's \copy