Re: pgsql: Implement error checking for pthreads calls in thread-safe mode. - Mailing list pgsql-committers

From Gregory Stark
Subject Re: pgsql: Implement error checking for pthreads calls in thread-safe mode.
Date
Msg-id 87hccxjh6h.fsf@oxford.xeocode.com
Whole thread Raw
In response to pgsql: Implement error checking for pthreads calls in thread-safe mode.  (mha@postgresql.org (Magnus Hagander))
List pgsql-committers
"Magnus Hagander" <mha@postgresql.org> writes:

> Log Message:
> -----------
> Implement error checking for pthreads calls in thread-safe mode. They really
> should always succeed, but in the likely event of a failure we would
> previously fall through *without locking* - the new code will exit(1).
>
> Printing the error message on stderr will not work for all applications, but
> it's better than nothing at all - and our API doesn't provide a way to return
> the error to the caller.

If you want to print an error I think you have to use write(2) here instead of
fprintf. if pthread is cocked up then fprintf is going to have trouble locking
the buffer.

--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com
  Ask me about EnterpriseDB's On-Demand Production Tuning

pgsql-committers by date:

Previous
From: adunstan@postgresql.org (Andrew Dunstan)
Date:
Subject: pgsql: fix ecpg regression tests broken by over-eager adding of
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Remove DEFAULT_SYNC_FLAGBIT ...