copyParamList - Mailing list pgsql-hackers

From Andrew Gierth
Subject copyParamList
Date
Msg-id 87d1o76u1u.fsf@news-spur.riddles.org.uk
Whole thread Raw
Responses Re: copyParamList
List pgsql-hackers
copyParamList does not respect from->paramMask, in what looks to me like
an obvious oversight:
   retval->paramMask = NULL;
[...]       /* Ignore parameters we don't need, to save cycles and space. */       if (retval->paramMask != NULL &&
     !bms_is_member(i, retval->paramMask))
 

retval->paramMask is never set to anything not NULL in this function,
so surely that should either be initializing it to from->paramMask, or
checking from->paramMask in the conditional?

-- 
Andrew (irc:RhodiumToad)



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: 9.4 -> 9.5 regression with queries through pgbouncer on RHEL 6
Next
From: Alvaro Herrera
Date:
Subject: Re: [sqlsmith] PANIC: failed to add BRIN tuple