Re: [PATCH] pgpassfile connection option - Mailing list pgsql-hackers

From Julian Markwort
Subject Re: [PATCH] pgpassfile connection option
Date
Msg-id 87E81BF8-D177-45AF-BA68-23A0DF28D840@uni-muenster.de
Whole thread Raw
In response to Re: [PATCH] pgpassfile connection option  (Julian Markwort <julian.markwort@uni-muenster.de>)
Responses Re: [PATCH] pgpassfile connection option  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
I've updated my patch to work with the changes introduced to libpq by allowing multiple hosts.
On Fabien's recommendations, I've kept the variable dot_pgpassfile_used, however I renamed that to pgpassfile_used, to keep a consistent naming scheme.
I'm still not sure about the amount of error messages produced by libpq, I think it would be ideal to report an error while accessing a file provided in the connection string, however I would not report that same type of error when the .pgpass file has been tried to retrieve a password.
(Else, you'd get an error message on every connection string that doesn't specify a pgpassfile or password, since .pgpass will be checked every time, before prompting the user to input the password)

regards,
Julian Markwort
Attachment

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: [PATCH] Allow TAP tests to be run individually
Next
From: Magnus Hagander
Date:
Subject: Re: Remove the comment on the countereffectiveness of large shared_buffers on Windows