Re: GIST and TOAST - Mailing list pgsql-hackers

From Gregory Stark
Subject Re: GIST and TOAST
Date
Msg-id 878xea9c6w.fsf@stark.xeocode.com
Whole thread Raw
In response to Re: GIST and TOAST  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers
"Teodor Sigaev" <teodor@sigaev.ru> writes:

>> It doesn't actually crash, it just fails CHECKARRVALID. I added an assertion
>> in there to cause it to generate a core dump.
>
> Wow, catch that, see attached patch.
>
> g_int_decompress doesn't returns detoasted array in case it was empty.
> Previously it was safe because empty array never has been toasted.

Ah, thanks a bunch.

> Should I commit it or you'll include in your patch?

I'll include it in the patch I guess since it's fine the way it is until the
patch hits.

Now I'll try running the regressions again with the gist datatypes like hstore
etc all packed as well.


--  Gregory Stark EnterpriseDB          http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Plan invalidation vs. unnamed prepared statements
Next
From: Jeff Davis
Date:
Subject: Re: Bug: Buffer cache is not scan resistant