Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Parenthesize macro arguments safely. - Mailing list pgsql-committers

From Gregory Stark
Subject Re: pgsql: Parenthesize macro arguments safely.
Date
Msg-id 877imdbana.fsf@oxford.xeocode.com
Whole thread Raw
In response to pgsql: Parenthesize macro arguments safely.  (tgl@postgresql.org (Tom Lane))
List pgsql-committers
Tree view 
"Tom Lane" <tgl@postgresql.org> writes:

> Log Message:
> -----------
> Parenthesize macro arguments safely.  I see no bug among the current
> uses of PG_DETOAST_DATUM_SLICE, but it's clearly trouble waiting to
> happen.

If this is trouble waiting to happen it should probably be backported.
Otherwise a future bug fix could introduce a call to it and then be
backportted fix without anyone catching that the macro was defined
differently previously.

--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: mha@postgresql.org (Magnus Hagander)
Date:
Subject: pgsql: Properly pass -c parameter to ecpg when building regression
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Create a function variable "join_search_hook" to let plugins