Re: Text <-> C string - Mailing list pgsql-hackers

From Gregory Stark
Subject Re: Text <-> C string
Date
Msg-id 873ax7rc65.fsf@oxford.xeocode.com
Whole thread Raw
In response to Re: Text <-> C string  ("Brendan Jurd" <direvus@gmail.com>)
Responses Re: Text <-> C string
List pgsql-hackers
"Brendan Jurd" <direvus@gmail.com> writes:

> On 9/22/07, Gregory Stark <stark@enterprisedb.com> wrote:
>> The canonical way to do it is with
>>
>> DatumGetCString(DirectFunctionCall1(textout, t))
>
> Ah, I see.  Thanks.
>
> In that case, would it be helpful if I submitted a patch for the
> various code fragments that do this locally, updating them to use
> DatumGetCString?

I would be interested in seeing just a list of such places if you have it
handy. I don't think we consider it wrong to violate the text data type
abstraction barrier like you describe though. 

I'm interested because any such code is possibly either failing to take into
account toasted data or is unnecessarily detoasting packed varlenas.

--  Gregory Stark EnterpriseDB          http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: like/ilike improvements
Next
From: "Brendan Jurd"
Date:
Subject: Re: Text <-> C string