Re: [PATCH] add ssl_protocols configuration option - Mailing list pgsql-hackers

From Dag-Erling Smørgrav
Subject Re: [PATCH] add ssl_protocols configuration option
Date
Msg-id 86d28idyaw.fsf@nine.des.no
Whole thread Raw
In response to Re: [PATCH] add ssl_protocols configuration option  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [PATCH] add ssl_protocols configuration option  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> Alex Shulgin <ash@commandprompt.com> writes:
> > * The code allows specifying SSLv2 and SSLv3 in the GUC, but removes
> >   them forcibly after parsing the complete string (a warning is issued).
> >   Should we also add a note about this to the documentation?
> I see no reason to accept them at all, if we're going to reject them
> later anyway.
>
> We can argue (as was done earlier in this thread) if we can drop SSL
> 3.0 completely -- but we can *definitely* drop SSLv2, and we should.
> But anything that we're going to reject at a later stage anyway, we
> should reject early.

It's not really "early or late", but rather "within the loop or at the
end of it".  From the users' perspective, the difference is that they
get (to paraphrase) "SSLv2 is not allowed" instead of "syntax error" and
that they can use constructs such as "ALL:-SSLv2".

DES
--
Dag-Erling Smørgrav - des@des.no



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [PATCH] add ssl_protocols configuration option
Next
From: Jeff Davis
Date:
Subject: Re: group locking: incomplete patch, just for discussion