Modernize const handling with readline - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Modernize const handling with readline
Date
Msg-id 862fc1d4-9a0c-d2b6-5451-ee3dc750bcab@eisentraut.org
Whole thread Raw
Responses Re: Modernize const handling with readline
Re: Modernize const handling with readline
List pgsql-hackers
The comment

     /* On some platforms, readline is declared as readline(char *) */

is obsolete.  The casting away of const can be removed.

The const in the readline() prototype was added in GNU readline 4.2, 
released in 2001.  BSD libedit has also had const in the prototype since 
at least 2001.

(The commit that introduced this comment (187e865174) talked about 
FreeBSD 4.8, which didn't have readline compatibility in libedit yet, so 
it must have been talking about GNU readline in the base system.  This 
checks out, but already FreeBSD 5 had an updated GNU readline with const.)

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [PoC] pg_upgrade: allow to upgrade publisher node
Next
From: vignesh C
Date:
Subject: Re: Skip collecting decoded changes of already-aborted transactions