Postgres Pro
Downloads
Home   >   mailing lists

Re: Missing free_var() at end of accum_sum_final()? - Mailing list pgsql-hackers

From Joel Jacobson
Subject Re: Missing free_var() at end of accum_sum_final()?
Date
Msg-id 85efda6a-f047-4c55-a7bc-a46b0926c6bb@app.fastmail.com
Whole thread Raw
In response to Re: Missing free_var() at end of accum_sum_final()?  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: Missing free_var() at end of accum_sum_final()?  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Tree view 
On Fri, Mar 3, 2023, at 16:11, Dean Rasheed wrote:
> Attachments:
> * make-result-using-vars-buf-v2.patch

One suggestion: maybe add a comment explaining why the allocated buffer
which size is based on strlen(cp) for the decimal digit values,
is guaranteed to be large enough also for the result's digit buffer?

I.e. some kind of proof why

   (NUMERIC_HDRSZ + strlen(cp) + DEC_DIGITS * 2) >= ((ndigits + 1) * sizeof(NumericDigit)))

holds true in general.

/Joel

pgsql-hackers by date:

Previous
From: Gilles Darold
Date:
Subject: Re: [Proposal] Allow pg_dump to include all child tables with the root table
Next
From: Ankit Kumar Pandey
Date:
Subject: [Question] Similar Cost but variable execution time in sort