RE: A new function to wait for the backend exit after termination - Mailing list pgsql-hackers

From Hou, Zhijie
Subject RE: A new function to wait for the backend exit after termination
Date
Msg-id 85e5241ce9724b5ca5fbe02f3b05a929@G08CNEXMBPEKD05.g08.fujitsu.local
Whole thread Raw
In response to Re: A new function to wait for the backend exit after termination  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> > +    ereport(WARNING,
> > +            (errmsg("could not wait for the termination of the
> backend with PID %d within %ld milliseconds",
> > +                    pid, timeout)));
>
> > The code use %ld to print int64 type.
> > How about use INT64_FORMAT, which looks more appropriate.
>
> This is a translatable message, so INT64_FORMAT is no good -- we need
> something that is the same across platforms.  The current project standard
> for this problem is to use "%lld" and explicitly cast the argument to long
> long int to match that.

Thank you for pointing out that,
And sorry for did not think of it.

Yes, we can use %lld, (long long int) timeout.

Best regards,
houzj





pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Renaming cryptohashes.c to cryptohashfuncs.c
Next
From: Tatsuo Ishii
Date:
Subject: Re: Deprecate custom encoding conversions