On March 15, 2017 12:33:28 PM PDT, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Andres Freund <andres@anarazel.de> writes:
>> [ latest patches ]
>
>I looked through 0002-Make-get_last_attnums-more-generic.patch.
>So for my money, you should drop 0002 altogether and just have 0004
>remove get_last_attnums() from execUtils.c and stick it into
>execExpr.c. I suppose you still need the LastAttnumInfo API change
>so as to decouple it from ProjectionInfo, but that's minor.
I think it's quite useful in other places too, we do repeated slot-getattrs in a bunch of places in the executor, and
it'snoticeable performance wise.
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
