Re: Linux LSB init script - Mailing list pgsql-hackers

From Wolfgang Wilhelm
Subject Re: Linux LSB init script
Date
Msg-id 854062.48757.qm@web23208.mail.ird.yahoo.com
Whole thread Raw
In response to Re: Linux LSB init script  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
Responses Re: Linux LSB init script
List pgsql-hackers
Hello Kevin,

a technical comment about line 71 and following of your shell script:

# Check that we have one parameter: action
if [ $# -ne 1 ] ; then
  if [ $# -lt 1 -o "$1" = "" ] ] ; then
    log_failure_msg "$0: action not specified"
  else
    log_failure_msg "$0: too many parameters"
  fi
  log_warning_msg "$usage"
  exit 2
fi
action="$1"

I think in the second "if" there's a closing square bracket too much.

Wolfgang


Von: Kevin Grittner <Kevin.Grittner@wicourts.gov>
An: Andrew Dunstan <andrew@dunslane.net>
CC: David Fetter <david@fetter.org>; Greg Stark <gsstark@mit.edu>; pgsql-hackers@postgresql.org
Gesendet: Montag, den 31. August 2009, 21:06:22 Uhr
Betreff: Re: [HACKERS] Linux LSB init script

Andrew Dunstan <andrew@dunslane.net> wrote:

> cvsutils

That allowed me to use 'cvsdo add' and 'cvs diff -cN' to generate the
attached.  This contains a couple minor fixes to what I posted in "new
file" form.  I was holding off on the CommitFest entry until I sorted
out the format; I'll link here as version 1 of the patch.

-Kevin


Attachment

pgsql-hackers by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Re: community decision-making & 8.5
Next
From: Alvaro Herrera
Date:
Subject: Re: remove flatfiles.c