Re: Hide exposed impl detail of wchar.c - Mailing list pgsql-hackers

From Eric Ridge
Subject Re: Hide exposed impl detail of wchar.c
Date
Msg-id 8455C6A3-786E-41DC-A004-B576519E602F@gmail.com
Whole thread Raw
In response to Re: Hide exposed impl detail of wchar.c  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
> On Nov 20, 2023, at 7:10 PM, Andres Freund <andres@anarazel.de> wrote:
>
>
> What I don't quite get is why SIMD headers are particularly more problematic
> than others - there's other headers that are compiler specific?

The short answer is the rust-based bindings generation tool pgrx uses (bindgen) is a little brain dead and gets
confusedwhen there’s multiple compiler builtins headers on the host. 

This simd header is the first of its kind we’ve run across that’s exposed via Postgres’ “public api”. And bindgen wants
tofollow all the includes, it gets confused, picks the wrong one, and then errors happen. 

And I don’t know that it makes much sense for Postgres to include such a header into 3rd-party code anyways.

I think Jubilee is also working with them to fix this, but we’re hoping Jubilee’s patch here (or similar) can get
mergedso we can clear our build drama. 

eric


pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: How to accurately determine when a relation should use local buffers?
Next
From: Aleksander Alekseev
Date:
Subject: Re: Annoying build warnings from latest Apple toolchain