Re: BUG #17777: An assert failed in nodeWindowAgg.c - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #17777: An assert failed in nodeWindowAgg.c
Date
Msg-id 842393.1676218781@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #17777: An assert failed in nodeWindowAgg.c  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: BUG #17777: An assert failed in nodeWindowAgg.c  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-bugs
David Rowley <dgrowleyml@gmail.com> writes:
> On Sat, 11 Feb 2023 at 13:49, Andres Freund <andres@anarazel.de> wrote:
>> I think we could just add a !contain_subplans() to the code deciding whether
>> it's safe to use the movable window optimization?

> I think this is a fair way to fix the bug.

Agreed.

> Here's a patch for that.

Why is it okay to check only the filter, and not the rest of the
WindowFunc's subexpressions?  The arguments we've just run through
seem to apply to a subplan in the direct or aggregated arguments
as well.

            regards, tom lane



pgsql-bugs by date:

Previous
From: David Rowley
Date:
Subject: Re: BUG #17777: An assert failed in nodeWindowAgg.c
Next
From: Tom Lane
Date:
Subject: Re: BUG #17788: Incorrect memory access when parsing empty string as sql_standard interval