Re: non-bulk inserts and tuple routing - Mailing list pgsql-hackers

From Amit Langote
Subject Re: non-bulk inserts and tuple routing
Date
Msg-id 8399fd28-07c2-3cbc-f807-f89cdf2f98f5@lab.ntt.co.jp
Whole thread Raw
In response to Re: non-bulk inserts and tuple routing  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: non-bulk inserts and tuple routing
List pgsql-hackers
Fujita-san,

On 2018/01/30 18:22, Etsuro Fujita wrote:
> (2018/01/25 18:52), Amit Langote wrote:
>> On 2018/01/25 18:30, Etsuro Fujita wrote:
>>> The patches apply cleanly and compile successfully, but make check fails
>>> in an assert-enabled build.
>>
>> Hmm, I can't seem to reproduce the failure with v4 patches I posted
>> earlier today.
> 
>> Can you please post the errors you're seeing?
> 
> A quick debug showed that the failure was due to a segmentation fault
> caused by this change to ExecSetupPartitionTupleRouting (in patch
> v4-0003-During-tuple-routing-initialize-per-partition-obj):
> 
> -    bool        is_update = false;
> 
> +    bool        is_update;
> 
> I modified that patch to initialize the is_update to false as before. With
> the modified version, make check passed successfully.

Oops, my bad.

> I'll review the patch in more detail!

Thank you.  Will wait for your comments before sending a new version then.

Regards,
Amit



pgsql-hackers by date:

Previous
From: atorikoshi
Date:
Subject: Re: User defined data types in Logical Replication
Next
From: Simon Riggs
Date:
Subject: Re: [HACKERS] MERGE SQL Statement for PG11