Re: change regexp_substr first argument make tests more easier to understand. - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: change regexp_substr first argument make tests more easier to understand.
Date
Msg-id 839433fd-1ce7-485d-b42a-76e094781a91@enterprisedb.com
Whole thread Raw
In response to Re: change regexp_substr first argument make tests more easier to understand.  (jian he <jian.universality@gmail.com>)
Responses Re: change regexp_substr first argument make tests more easier to understand.
List pgsql-hackers
Hi,

If I understand correctly, the problem is that it's not clear which of
the 'abc' substrings is matched/returned by the function, right?

I wonder if this is a problem only for understanding the test, or if it
makes the tests a bit weaker. I mean, what if the function returns the
wrong substring? How would we know?

Also, if we tweak this, shouldn't we tweak also the regext_instr() calls
a bit earlier in the test script?


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: add function argument names to regex* functions.
Next
From: Tom Lane
Date:
Subject: Re: psql: fix variable existence tab completion