Re: [COMMITTERS] pgsql: Clean up Perl code according toperlcritic - Mailing list pgsql-hackers

On 03/28/2017 05:23 AM, Dagfinn Ilmari Mannsåker wrote:
> +        @opts = grep { !/\$\(/ && /^--/ }
> +            map { (my $x = $_) =~ s/\Q$(top_builddir)\E/\"$topdir\"/; $x;}
> +            split(/\s+/, $1);
>      


The use of this lexical $x variable seems entirely pointless and
obfuscatory. If perlcritic doesn't like it without then that's another
black mark against it IMNSHO.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services