Re: pageinspect: Hash index support - Mailing list pgsql-hackers

On 09/26/2016 10:45 PM, Peter Eisentraut wrote:
> On 9/26/16 1:39 PM, Jesper Pedersen wrote:
>> Left as is, since BuildTupleFromCStrings() vs. xyzGetDatum() are equally
>> readable in this case. But, I can change the patch if needed.
>
> The point is that to use BuildTupleFromCStrings() you need to convert
> numbers to strings, and then they are converted back.  This is not a
> typical way to write row-returning functions.
>

Ok.

Changed:
  * BuildTupleFromCStrings -> xyzGetDatum
  * 'type' field: char -> text w/ full description
  * Removed 'type' information from documentation

Best regards,
  Jesper