Re: PATCH: Unlogged tables re-initialization tests - Mailing list pgsql-hackers

From David Steele
Subject Re: PATCH: Unlogged tables re-initialization tests
Date
Msg-id 8325689c-9b56-e489-b6f9-c6bf5822cbc9@pgmasters.net
Whole thread Raw
In response to Re: PATCH: Unlogged tables re-initialization tests  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: PATCH: Unlogged tables re-initialization tests  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
List pgsql-hackers
On 3/12/18 11:27 AM, Peter Eisentraut wrote:
> On 3/11/18 05:11, Michael Paquier wrote:
>> On Fri, Mar 09, 2018 at 05:23:48PM -0500, Peter Eisentraut wrote:
>>> This seems like a useful test.
>>>
>>> On 3/5/18 12:35, David Steele wrote:
>>>> +mkdir($tablespaceDir)
>>>> +    or die "unable to mkdir \"$tablespaceDir\"";
>>>
>>> Use BAIL_OUT instead of die in tests.
>>
>> Would it be better to make this practice more uniform?  From the code of
>> the tests:
>> $ git grep die -- */t/*.pl | wc -l
>> 50
> 
> Yes, or maybe there is a way to "catch" die and turn it into BAIL_OUT?

something like this should work:

# Convert die to BAIL_OUT
$SIG{__DIE__} = sub {BAIL_OUT(@_)};

-- 
-David
david@pgmasters.net


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: PATCH: Unlogged tables re-initialization tests
Next
From: Pavel Luzanov
Date:
Subject: Re: [HACKERS] proposal: schema variables