pg_regress: Treat child process failure as test failure - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject pg_regress: Treat child process failure as test failure
Date
Msg-id 82C46B5E-1821-4039-82C2-56BCA5992989@yesql.se
Whole thread Raw
Responses Re: pg_regress: Treat child process failure as test failure
List pgsql-hackers
In the thread about TAP format out in pg_regress, Andres pointed out [0] that
we allow a test to pass even if the test child process failed.  While its
probably pretty rare to have a test pass if the process failed, this brings a
risk for false positives (and it seems questionable that any regress test will
have a child process failing as part of its intended run).

The attached makes child failures an error condition for the test as a belts
and suspenders type check. Thoughts?

--
Daniel Gustafsson        https://vmware.com/

[0] https://postgr.es/m/20221122235636.4frx7hjterq6bmls@awork3.anarazel.de


Attachment

pgsql-hackers by date:

Previous
From: "Jonathan S. Katz"
Date:
Subject: Re: User functions for building SCRAM secrets
Next
From: Daniel Gustafsson
Date:
Subject: Re: TAP output format in pg_regress