Re: Common function for percent placeholder replacement - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Common function for percent placeholder replacement
Date
Msg-id 8228593d-1ebc-e061-2c61-3815bb364385@enterprisedb.com
Whole thread Raw
In response to Re: Common function for percent placeholder replacement  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Common function for percent placeholder replacement  (Corey Huinker <corey.huinker@gmail.com>)
Re: Common function for percent placeholder replacement  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
On 19.12.22 10:51, Alvaro Herrera wrote:
> I think the new one is not great.  I wish we could do something more
> straightforward, maybe like
> 
>    replace_percent_placeholders(base_command,
>                                 PERCENT_OPT("f", filename),
>                                 PERCENT_OPT("d", target_detail));
> 
> Is there a performance disadvantage to a variadic implementation?
> Alternatively, have all these macro calls form an array.

How about this new one with variable arguments?

(Still need to think about Robert's comment about lack of error context.)

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: meson files copyright
Next
From: John Naylor
Date:
Subject: Re: [PoC] Improve dead tuple storage for lazy vacuum