Re: BUG #1270: stack overflow in thread in fe_getauthname - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #1270: stack overflow in thread in fe_getauthname
Date
Msg-id 8224.1096328754@sss.pgh.pa.us
Whole thread Raw
In response to BUG #1270: stack overflow in thread in fe_getauthname  ("PostgreSQL Bugs List" <pgsql-bugs@postgresql.org>)
Responses Re: BUG #1270: stack overflow in thread in fe_getauthname  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-bugs
"PostgreSQL Bugs List" <pgsql-bugs@postgresql.org> writes:
> With the THREAD_SAFETY changes, a buffer is defined on the stack as:
> char       pwdbuf[BUFSIZ];
> This buffer overflows the stack when used in a thread.  As the application
> creating the thread cannot be modified to increase the stack size, it would
> probably be prudent to reduce this buffer size (I believe that BUFSIZ is
> around 8192 bytes on most modern Unix implementations).

No, it would be prudent to fix the app.  While this one particular
buffer might be larger than needed, we are *not* going to buy into the
notion that libpq needs to run successfully in an 8K stack.  This
particular problem is only the tip of the iceberg; hewing to any
such limit is going to require far more drastic changes that just don't
seem worthwhile.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: BUG #1270: stack overflow in thread in fe_getauthname
Next
From: Tom Lane
Date:
Subject: Re: BUG #1270: stack overflow in thread in fe_getauthname