Re: Readd use of TAP subtests - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Readd use of TAP subtests
Date
Msg-id 7e67b831-9eae-cd19-c96c-c1e59d916498@dunslane.net
Whole thread Raw
In response to Re: Readd use of TAP subtests  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: Readd use of TAP subtests  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Re: Readd use of TAP subtests  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 12/8/21 09:08, Dagfinn Ilmari Mannsåker wrote:
>
> Either way, I think we should be switching tests to done_testing()
> whenever it would otherwise have to adjust the test count, to avoid
> having to do that again and again and again going forward.
>

I'm not so sure. I don't think its necessarily a bad idea to have to
declare how many tests you're going to run. I appreciate it gets hard in
some cases, which is why we have now insisted on a Test::More version
that supports subtests. I suppose we could just take the attitude that
we're happy with however many tests it actually runs, and as long as
they all pass we're good. It just seems slightly sloppy.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: Readd use of TAP subtests
Next
From: Fujii Masao
Date:
Subject: Re: Shouldn't postgres_fdw report warning when it gives up getting result from foreign server?