Fix inappropriate uses of PG_GETARG_UINT32() - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Fix inappropriate uses of PG_GETARG_UINT32()
Date
Msg-id 7e43869b-d412-8f81-30a3-809783edc9a3@enterprisedb.com
Whole thread Raw
Responses Re: Fix inappropriate uses of PG_GETARG_UINT32()  ("Bossart, Nathan" <bossartn@amazon.com>)
List pgsql-hackers
I noticed that the chr() function uses PG_GETARG_UINT32() to get its 
argument, even though the argument is a (signed) int.  So you get some 
slightly silly behavior like this:

=> select chr(-333);
ERROR:  54000: requested character too large for encoding: -333

The attached patch fixes this by accepting the argument using 
PG_GETARG_INT32(), doing some checks, and then casting it to unsigned 
for the rest of the code.

The patch also fixes another inappropriate use in an example in the 
documentation.  These two were the only inappropriate uses I found, 
after we had fixed a few recently.
Attachment

pgsql-hackers by date:

Previous
From: Kenaniah Cerny
Date:
Subject: Re: Proposal: allow database-specific role memberships
Next
From: "Bossart, Nathan"
Date:
Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file