Re: [PATCH] Disable bgworkers during servers start in pg_upgrade - Mailing list pgsql-hackers

From Denis Laxalde
Subject Re: [PATCH] Disable bgworkers during servers start in pg_upgrade
Date
Msg-id 7d470953-07cb-f9dc-f7b3-d33697644b54@dalibo.com
Whole thread Raw
In response to [PATCH] Disable bgworkers during servers start in pg_upgrade  (Denis Laxalde <denis.laxalde@dalibo.com>)
Responses Re: [PATCH] Disable bgworkers during servers start in pg_upgrade  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
Michael Paquier a écrit :
>> @@ -5862,6 +5862,9 @@ do_start_bgworker(RegisteredBgWorker *rw)
>>   static bool
>>   bgworker_should_start_now(BgWorkerStartTime start_time)
>>   {
>> +    if (IsBinaryUpgrade)
>> +        return false;
>> +
> Using -c max_worker_processes=0 would just have the same effect, no?
> So we could just patch pg_upgrade's server.c to get the same level of
> protection?

Yes, same effect indeed. This would log "too many background workers" 
messages in pg_upgrade logs, though.
See attached patch implementing this suggestion.

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Skipping logical replication transactions on subscriber side
Next
From: Denis Smirnov
Date:
Subject: Re: Async-unsafe functions in signal handlers