PATCH: add "--config-file=" option to pg_rewind - Mailing list pgsql-hackers

From Gunnar \"Nick\" Bluth
Subject PATCH: add "--config-file=" option to pg_rewind
Date
Msg-id 7c59265d-ac50-b0aa-ca1e-65e8bd27642a@pro-open.de
Whole thread Raw
Responses Re: PATCH: add "--config-file=" option to pg_rewind
Re: PATCH: add "--config-file=" option to pg_rewind
List pgsql-hackers
Hi!

During a Patroni PR discussion 
(https://github.com/zalando/patroni/pull/2225), we realised that if one 
wants to use the "-c" option on a typical Debian/Ubuntu installation 
(where the config resides below /etc/postgresql/), pg_rewind needs a way 
to be told where the postgresql.conf actually is.

The attached patch implements this as an option.

I'm extremely unhappy that I called it "--config-file" here, while 
"postgres" itself wants "--config_file". But as the other dashed options 
of pg_rewind are, well, dashed and not underscored, it seemed to be 
better that the other way...

As the "-c" feature appeared in 12 and existing Debian installations are 
unable to use it right now, I suggest to even backport the patch.

Oh, and I'm still not subscribed to -hackers, so the usual "please CC 
me" applies!

Best regards,
-- 
Gunnar "Nick" Bluth

Eimermacherweg 106
D-48159 Münster

Mobil +49 172 8853339
Email: gunnar.bluth@pro-open.de
__________________________________________________________________________
"Ceterum censeo SystemD esse delendam" - Cato
Attachment

pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: List of all* PostgreSQL EXTENSIONs in the world
Next
From: Tom Lane
Date:
Subject: Re: Frontend error logging style