Re: Built-in CTYPE provider - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Built-in CTYPE provider
Date
Msg-id 7c48fd9170b69b5dce952741cdb257e8dce88f64.camel@j-davis.com
Whole thread Raw
In response to Re: Built-in CTYPE provider  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Built-in CTYPE provider
List pgsql-hackers
On Mon, 2024-03-18 at 18:04 -0400, Tom Lane wrote:
> This is causing all CI jobs to fail the "compiler warnings" check.

I did run CI before checkin, and it passed:

https://cirrus-ci.com/build/5382423490330624

If I open up the windows build, I see the warning:

https://cirrus-ci.com/task/5199979044667392

but I didn't happen to check this time.

> Probably the best fix is the traditional
>
>         return <something>;    /* keep compiler quiet */
>
> but I'm not sure what the best default result is in this function.

In inverted the check so that I didn't have to choose a default.

Regards,
    Jeff Davis




pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: sslinfo extension - add notbefore and notafter timestamps
Next
From: Paul Jungwirth
Date:
Subject: Re: SQL:2011 application time