Postgres Pro
Downloads
Home   >   mailing lists

Re: Quoting filename in using facing log messages - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Quoting filename in using facing log messages
Date
Msg-id 7bc486db-9888-7d23-2cae-6068b506785f@eisentraut.org
Whole thread Raw
In response to Quoting filename in using facing log messages  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Quoting filename in using facing log messages
List pgsql-hackers
Tree view 
On 13.09.23 13:48, Daniel Gustafsson wrote:
> Looking at ZQFUGOuS5DU4DsE4@paquier.xyz I noticed that we had a a few instances
> of filenames in userfacing log messages (ie not elog or DEBUGx etc) not being
> quoted, where the vast majority are quoted like \"%s\".  Any reason not to
> quote them as per the attached to be consistent across all log messages?

Since WAL file names have a predictable format, there is less pressure 
to quote them to avoid ambiguities.  But in general we should try to be 
consistent, so your patch makes sense to me.

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Synchronizing slots from primary to standby
Next
From: Daniel Gustafsson
Date:
Subject: Re: Quoting filename in using facing log messages