Re: TAP tests aren't using the magic words for Windows file access - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: TAP tests aren't using the magic words for Windows file access
Date
Msg-id 7b2459d7-2414-4a19-d137-2abef70fcc19@2ndQuadrant.com
Whole thread Raw
In response to Re: TAP tests aren't using the magic words for Windows file access  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 11/6/19 4:43 PM, Tom Lane wrote:
> =?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= <juanjo.santamaria@gmail.com> writes:
>> Please find attached a patch that adds the FILE_SHARE options to
>> TestLib::slurp_file using Win32API::File.
> Ick.  Are we going to need Windows-droppings like this all over the
> TAP tests?  I'm not sure I believe that slurp_file is the only place
> with a problem.
>
>             



In any case, the patch will fail as written - on the Msys 1 system I
just tested Win32::API is not available to the DTK perl we need to use
to run TAP tests.


cheers


andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Missing test of SPI copy functionality
Next
From: Bruce Momjian
Date:
Subject: Re: [Proposal] Table-level Transparent Data Encryption (TDE) and KeyManagement Service (KMS)