Postgres Pro
Downloads
Home   >   mailing lists

Re: CREATE TABLE ( .. STORAGE ..) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: CREATE TABLE ( .. STORAGE ..)
Date
Msg-id 7a2883e1-ce7d-65cb-4ef7-a7822e5e4b46@enterprisedb.com
Whole thread Raw
In response to Re: CREATE TABLE ( .. STORAGE ..)  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
Tree view 
On 15.06.22 16:51, Aleksander Alekseev wrote:
> I noticed that cfbot is not entirely happy with the patch, so I rebased it.
> 
>> I see that COMPRESSION and STORAGE now are handled slightly
>> differently in the grammar. Maybe we could standardize that a bit
>> more; so that we have only one `STORAGE [kind]` definition in the
>> grammar?
>>
>> As I'm new to the grammar files; would you know the difference between
>> `name` and `ColId`, and why you would change from one to the other in
>> ALTER COLUMN STORAGE?
> 
> Good point, Matthias. I addressed this in 0002. Does it look better now?

In your patch, the documentation for CREATE TABLE says "SET STORAGE", 
but the actual syntax does not contain "SET".

pgsql-hackers by date:

Previous
From: "Drouvot, Bertrand"
Date:
Subject: SYSTEM_USER reserved word implementation
Next
From: Peter Eisentraut
Date:
Subject: Re: CREATE TABLE ( .. STORAGE ..)