Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed - Mailing list pgadmin-hackers

Hello,

Any Feedback on this Patch?

We have other changes that we already developed that depend on this change.

Thanks

On Tue, Feb 6, 2018 at 9:33 AM Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hello,

Any feedback on this Patch?

Thanks

Joao

On Fri, Feb 2, 2018 at 5:50 PM Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hi Hackers,

This is quite a big patch in order to solve the problem with the Explain Plan.

We sent 2 patches that have the following:

- update-javascript-packages.diff 

    Add package:

     is-docker to select a specific setting when running the Chrome tests in

     Docker

    Upgrade the version of:

    - babel-loader

    - extract-text-webpack-plugin

    - jasmine-core

    - jasmine-enzyme

    - moment

- explain-plan-greenplum.diff

  Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them

  Extract SQLEditor backend functions that start executing query to their own files and add tests around it

  Move the Explain SQL from the front-end and now pass the Explain plan parameters as a JSON object in the start query call.

  Extract the compile_template_name into a function that can be used by the different places that try to select the version of the template and the server type

Thanks

Joao