Re: PATCH pass PGOPTIONS to pg_regress - Mailing list pgsql-hackers

From Manuel Kniep
Subject Re: PATCH pass PGOPTIONS to pg_regress
Date
Msg-id 7EF6F1ED-E33C-4E0C-9B02-A889C9F4C31A@adeven.com
Whole thread Raw
In response to Re: PATCH pass PGOPTIONS to pg_regress  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
> Am 30.05.2018 um 17:22 schrieb Michael Paquier <michael@paquier.xyz>:
>
> On Wed, May 30, 2018 at 12:28:27PM +0300, Ildar Musin wrote:
>> Here extra.conf is implied to be a file in extension's root directory which
>> contains additional server options.
>> This would only work for `make check` though, not `make installcheck`.
>
> REGRESS_OPTS is more widely known for this purpose, and I use it as
> well.  Still, I agree that there is no need to add an extra mechanism
> with PGOPTIONS if a feature already exists.  One thing which is also

--temp-config is only supported in temp-instance mode which I wanted to avoid

But if you think that this feature is supported enough by this I agree it doesn’t make sense
to add something. I just don’t see any disadvantage in my approach.

Manuel

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: documentation fixes for partition pruning, round two
Next
From: Michael Paquier
Date:
Subject: Re: pg_replication_slot_advance to return NULL instead of 0/0 ifslot not advanced