Re: [HACKERS] Additional logging for VACUUM and ANALYZE - Mailing list pgsql-hackers

From Bossart, Nathan
Subject Re: [HACKERS] Additional logging for VACUUM and ANALYZE
Date
Msg-id 7EA13C25-BC89-4998-8541-F143C56BE0C5@amazon.com
Whole thread Raw
In response to Re: [HACKERS] Additional logging for VACUUM and ANALYZE  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Additional logging for VACUUM and ANALYZE
List pgsql-hackers
On 12/1/17, 2:03 PM, "Robert Haas" <robertmhaas@gmail.com> wrote:
> Thanks.  I think this looks fine now, except that (1) it needs a
> pgindent run and (2) I vote for putting the test case back.  Michael
> thought the test case was too much because this is so obscure, but I
> think that's exactly why it needs a test case.  Otherwise, somebody a
> few years from now may not even be able to figure out how to hit this
> message, and if it gets broken, we won't know.  This code seems to be
> fairly easy to break in subtle ways, so I think more test coverage is
> good.

Makes sense.  I ran pgindent and re-added the test case for v6 of the
patch.

Nathan


Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: BUG #14941: Vacuum crashes
Next
From: Tomas Vondra
Date:
Subject: Re: [HACKERS] Custom compression methods