On 10/29/21, 5:07 PM, "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
> "Bossart, Nathan" <bossartn@amazon.com> writes:
>> Well, as of bf6b9e9, "ALTER ROLE nathan PASSWORD ''" is effectively
>> the same as "ALTER ROLE nathan PASSWORD NULL". I agree about the
>> user-unfriendliness, but maybe simple_prompt() ignoring control-C is
>> the root-cause of the user-unfriendliness.
>
> I was afraid somebody would say that. I have looked at it, but AFAICS
> we'd have to duplicate all of sprompt.c and nearly all of pg_get_line.c
> in order to tie it into psql's SIGINT infrastructure, since we wouldn't
> dare enable the signal handler except during the innermost fgets() call,
> and if we did get a signal we'd still need to clean up the terminal echo
> state, so we couldn't just longjmp out of simple_prompt(). The
> cost/benefit ratio of that doesn't look very good.
Hm. Is it really necessary to duplicate all of sprompt.c and
pg_get_line.c? Would it be possible to teach the existing functions
how to optionally enable SIGINT handling instead? I wouldn't mind
trying my hand at this if it seems like a reasonable approach.
Nathan
