Re: longfin missing gssapi_ext.h - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: longfin missing gssapi_ext.h
Date
Msg-id 79A74001-61EB-467C-988A-424C9305BD94@yesql.se
Whole thread Raw
In response to Re: longfin missing gssapi_ext.h  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
> On 12 Apr 2023, at 16:55, Stephen Frost <sfrost@snowman.net> wrote:
>
> Greetings,
>
> * Daniel Gustafsson (daniel@yesql.se) wrote:
>>> On 12 Apr 2023, at 16:33, Stephen Frost <sfrost@snowman.net> wrote:
>>> Sure, reworked that way and attached.
>>
>> While not changed in this hunk, does the comment regarding Heimdal still apply?
>>
>> @@ -918,6 +919,7 @@ pg_GSS_recvauth(Port *port)
>>     int            mtype;
>>     StringInfoData buf;
>>     gss_buffer_desc gbuf;
>> +    gss_cred_id_t delegated_creds;
>>
>>     /*
>>      * Use the configured keytab, if there is one.  Unfortunately, Heimdal
>
> Good catch.  No, it doesn't.  I'm not anxious to actually change that
> code at this point but we could certainly consider changing it in the
> future.  I'll update this comment (and the identical one in
> secure_open_gssapi) accordingly.

Sounds like a good plan.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: [PATCH] Allow Postgres to pick an unused port to listen
Next
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: Direct I/O