Re: win32 version info - Mailing list pgsql-patches

From Tom Lane
Subject Re: win32 version info
Date
Msg-id 7971.1090867062@sss.pgh.pa.us
Whole thread Raw
In response to win32 version info  ("Magnus Hagander" <mha@sollentuna.net>)
List pgsql-patches
"Magnus Hagander" <mha@sollentuna.net> writes:
> This patch along with the attached files (.tar.gz unpacks in src/) adds
> VERSIONINFO to all binaries under win32.

Ya know, this is the sort of invasive junk that I was afraid people
would try to force on us for the Windows port :-(.

Can't you localize this into a single build rule somewhere?  And surely
we do not need to maintain a boilerplate .rc file for every executable.

> Finally, the patch adds an elephant icon to psql.exe (so it'll go nicely
> in the start menu for example).

You need a lot better reason than that to convince me to put a binary
file into CVS.

            regards, tom lane

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: win32 version info
Next
From: "Magnus Hagander"
Date:
Subject: Re: win32 version info