Re: report expected contrecord size - Mailing list pgsql-hackers

From Tom Lane
Subject Re: report expected contrecord size
Date
Msg-id 796879.1599172922@sss.pgh.pa.us
Whole thread Raw
In response to Re: report expected contrecord size  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: report expected contrecord size  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2020-Sep-03, Tom Lane wrote:
>> Uh ... is it really possible for gotlen to be more than total_len?
>> (I've not looked at the surrounding code here, but that seems weird.)

> Well, as I understand, total_len comes from one page, and gotlen comes
> from the continuation record(s) in the next page(s) of WAL.  So if
> things are messed up, it could happen.  (This *is* the code that
> validates the record, so it can't make too many assumptions.)

Got it.  No further objections.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: report expected contrecord size
Next
From: Tom Lane
Date:
Subject: Re: Maximum password length